support Node.js v26#1016
Conversation
| #endif | ||
| } | ||
| inline v8::Local<v8::Object> Holder() const { | ||
| #if defined(NAN_HAS_PROPERTY_CALLBACK_INFO_HOLDER_V2) |
There was a problem hiding this comment.
| #if defined(NAN_HAS_PROPERTY_CALLBACK_INFO_HOLDER_V2) | ||
| template<> | ||
| template <typename S> | ||
| inline void ReturnValue<void>::Set(const v8::Local<S> &) {} |
There was a problem hiding this comment.
|
I believe failure on Node.js v16 and v17 are not related to my changes 🤔 Can someone help on this please? |
|
CI on Node.js v16 and v17 no longer runs on |
|
The CI fails on v16 and v17 on current release branch see #1018 |
|
@agracio is this one good to land? |
|
I am not a maintainer of nan, to my knowledge only @kkoopa can approve, merge and release. |
|
This looks good to me. I have no clue why the two checks are failing, seems like the CI environment or node and its packages has broken itself somehow, but it is not related to this PR. |
|
The errors seem to stem from this not being available before 18.19 https://nodejs.org/api/diagnostics_channel.html#diagnostics_channeltracingchannelnameorchannels, but I do not know what it is, nor what or why something is relying on it. |
4 participants
This PR adds support for Node.js v26.
It comes with V8 14.6 which introduces breaking changes around
v8::PropertyCallbackInfo:Holder()is removed ->HolderV2().This()is removed.ReturnValue<void>::Set(Local<S>)no longer accepts object values